Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page loading): condition for more button #95

Merged
merged 5 commits into from
Feb 19, 2024
Merged

fix(page loading): condition for more button #95

merged 5 commits into from
Feb 19, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Feb 14, 2024 •
edited
Loading

Description

update the condition to show more button based on the data available

Why

more button is not visible

Issue

#439

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk marked this pull request as ready for review February 14, 2024 08:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oyo oyo merged commit 88bb57c into eclipse-tractusx:main Feb 19, 2024
6 checks passed
@oyo oyo deleted the issues/439-more-button branch February 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@lavanya-bmw lavanya-bmw Awaiting requested review from lavanya-bmw

@nidhigarg-bmw nidhigarg-bmw Awaiting requested review from nidhigarg-bmw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manojava-gk @oyo