docs(edr): Update 07_edrs.md #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Provider Data Plane: | ||
| Once the right EDR has been identified using the EDR Management API via the correct asset/agreement/transfer-process that | ||
| you want to transfer, we can use the `endpoint` and `authorization` information from the EDRto make the request. The `endpoint` | ||
| is used as the Host to which the request is sent and the `authorization` is used as the Token in the authorization header. |
There was a problem hiding this comment.
Suggested change
| is used as the Host to which the request is sent and the `authorization` is used as the Token in the authorization header. | |
| As in the example bellow, the `endpoint` is used as the Host to which the request is sent and the `authorization` replaces TOKEN in the `Authorization` header. |
There was a problem hiding this comment.
Fixed with a different proposal.
Co-authored-by: Rafael Magalhães <[email protected]>
Added Rafaels Suggestions
|
|
Even though its not mentioned anywhere in this repo (i thinkg), the name of the pr should adhere to the Eclipse EDC project contributing guidelines: https://github.com/eclipse-edc/docs/blob/main/CONTRIBUTING.md |
wolf4ood
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fixed the section about provider data plane data transfer in the edr chapter of the management walkthrough and added some more detailed explanation about how the request is build.
WHY
Incorrect example
FURTHER NOTES