Skip to content

Commit

Permalink
Remove support for deployableFeature option
Browse files Browse the repository at this point in the history
The deployableFeature option will create "standard eclipse update site
directory with feature content will be created under target folder" but
we already removed site-packaging from tycho for a while, if one wants
to archive similar a category.xml with eclipse-repository packaging
gives much more control and power to the user.
  • Loading branch information
laeubi committed Nov 24, 2023
1 parent a6dfcba commit a029c8f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 280 deletions.
6 changes: 6 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ If filtering provided artifacts is enabled, the repository references automatica
using exclusion and inclusion patterns and therefore allows more fine-grained control which references are added.
Additionally the automatically added references can be filter based on if they provide any of the filtered units or not.
If `addOnlyProviding` is `true` repositories that don't provide any filtered unit are not added to the assembled repo.

```xml
<plugin>
<groupId>org.eclipse.tycho</groupId>
Expand All @@ -98,6 +99,11 @@ If `addOnlyProviding` is `true` repositories that don't provide any filtered uni

```

### Remove support for deployableFeature option

The deployableFeature option will create "standard eclipse update site directory with feature content will be created under target folder" but we already removed site-packaging from Tycho for a while, if one wants to archive similar a category.xml with eclipse-repository packaging gives much more control and power to the user.


## 4.0.3

### new option to filter added repository-references when assembling a p2-repository
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,6 @@ public class PackageFeatureMojo extends AbstractTychoPackagingMojo {
@Parameter(property = "project.build.finalName", alias = "jarName", required = true)
private String finalName;

/**
* If set to <code>true</code>, standard eclipse update site directory with feature content will
* be created under target folder.
*/
@Parameter(defaultValue = "false")
private boolean deployableFeature = false;

@Parameter(defaultValue = "${project.build.directory}/site")
private File target;

Expand Down Expand Up @@ -200,10 +193,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
}

project.getArtifact().setFile(outputJar);

if (deployableFeature) {
assembleDeployableFeature();
}
}
}

Expand Down Expand Up @@ -278,11 +267,6 @@ private FileSet getManuallyIncludedFiles(BuildProperties buildProperties) {
return getFileSet(basedir, buildProperties.getBinIncludes(), binExcludes);
}

private void assembleDeployableFeature() throws MojoExecutionException {
UpdateSiteAssembler assembler = new UpdateSiteAssembler(plexus, target);
getTychoProjectFacet().getDependencyWalker(DefaultReactorProject.adapt(project)).walk(assembler);
}

private void expandVersionQualifiers(Feature feature) throws MojoFailureException {
ReactorProject reactorProject = DefaultReactorProject.adapt(project);
feature.setVersion(reactorProject.getExpandedVersion());
Expand Down

This file was deleted.

0 comments on commit a029c8f

Please sign in to comment.