Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducer for the .settings folder of a project is not considdered if it is a linked resource #1626

Closed
wants to merge 1 commit into from

Conversation

sthdev
Copy link

@sthdev sthdev commented Nov 4, 2022

This integration test tests if tycho follows project settings if the .settings folder of a project is a linked resource, which refers to another folder.

@laeubi
Copy link
Member

laeubi commented Oct 24, 2023

@sthdev can you please make sure to sign the ECA?

@sthdev
Copy link
Author

sthdev commented Oct 24, 2023

I did but there is no connection between my eclipse and my GitHub account. How would I do this?

@laeubi
Copy link
Member

laeubi commented Oct 24, 2023

I did but there is no connection between my eclipse and my GitHub account. How would I do this?

In your eclipse profile you can add the github user name, you must also make sure that the mail of the commit is the one you signed the ECA with.

@sthdev
Copy link
Author

sthdev commented Oct 24, 2023

Well, that's a problem. I did not sign the commits and I used a fake git user for technical reasons. I'll have to recommit the changes but I will not get around to do it before next week.

@sthdev sthdev force-pushed the issue_1364_reproducer branch from ec063ee to 043a938 Compare November 2, 2023 09:44
@sthdev
Copy link
Author

sthdev commented Nov 2, 2023

The commit email matches the ECA mail, now.

Copy link

github-actions bot commented Nov 2, 2023

Test Results

  591 files    591 suites   4h 2m 51s ⏱️
  399 tests   392 ✅  7 💤 0 ❌
1 197 runs  1 175 ✅ 22 💤 0 ❌

Results for commit a247c08.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the issue_1364_reproducer branch from 043a938 to a3689a1 Compare January 23, 2024 05:35
@laeubi laeubi changed the title Issue 1364 reproducer Reproducer for the .settings folder of a project is not considdered if it is a linked resource Feb 6, 2024
@laeubi laeubi force-pushed the issue_1364_reproducer branch from a3689a1 to 7f9cc60 Compare February 6, 2024 08:04
@laeubi
Copy link
Member

laeubi commented Feb 7, 2024

@sthdev it seems the test does not fail, can you check why it does not gives a failing test? Maybe one can better use a warning in the code, the enable failOnWarning in the settings of tycho but suppress the warning in the project settings.

Thsi should then result in a failing compile if project settings are not considered.

@laeubi laeubi force-pushed the issue_1364_reproducer branch from 7f9cc60 to a247c08 Compare March 12, 2024 05:19
@laeubi
Copy link
Member

laeubi commented May 5, 2024

Closing as no feedback from original author. @sthdev if this is still interesting for you please let me know so we can reopen the PR.

@laeubi laeubi closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants