Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tycho-its reproducer p2Repository.downloadVerifyNoDigestAlgo (#2710) #2711

Closed

Conversation

dhendriks
Copy link
Contributor

My first merge request to contribute a tycho-its. Hope it works.

Addresses #2710

@dhendriks dhendriks marked this pull request as ready for review August 13, 2023 15:18
@dhendriks dhendriks force-pushed the issue_2710_reproducer branch from 61ee82a to c8816bf Compare August 13, 2023 15:50
@dhendriks
Copy link
Contributor Author

For some reason my new test is not picked up. Any idea why?

@dhendriks
Copy link
Contributor Author

I think I found the problem. Let's see whether the next build works.

@dhendriks
Copy link
Contributor Author

dhendriks commented Aug 14, 2023

OK, the test is executed now. It fails as expected:

[ERROR] Errors: 
[ERROR]   DownloadVerifyNoDigestAlgoTest.test:23->AbstractTychoIntegrationTest.verifyTextNotInLog:256 » Verification Text 'No digest algorithm is available to verify download' was found in the log!
[INFO] 
[ERROR] Tests run: 360, Failures: 0, Errors: 1, Skipped: 6

The new integration test thus shows that Tycho currently gives the warnings that we don't want. What is the next step?

@laeubi
Copy link
Member

laeubi commented Aug 16, 2023

The new integration test thus shows that Tycho currently gives the warnings that we don't want. What is the next step?

Please squash/rebase your change so it could be uses as a basis for a possible fix. Do you maybe want to give it a try reducing the message for some of the items? At least for feature/products I think it could be a similar fix as applied for plugins already. For m2e target items it should be a bit different and reusing the maven checksums.

@dhendriks dhendriks force-pushed the issue_2710_reproducer branch from 6ae9154 to 3e5749f Compare August 16, 2023 13:13
@dhendriks
Copy link
Contributor Author

Please squash/rebase your change so it could be uses as a basis for a possible fix.

Done.

Do you maybe want to give it a try reducing the message for some of the items?

It already took me way more time than expected to report the issue, make a minimal reproducer, and get that in the right form as a tycho-its (4+ hours). At the moment I don't have the time to actually go fixing this. Especially since I know absolutely nothing about the internals of Tycho, so it would be a huge effort to figure out where it is, what is going on, and how to address that. I was kind of hoping some Tycho developer could look at it?

@laeubi laeubi force-pushed the issue_2710_reproducer branch from 3e5749f to 9b4de36 Compare December 5, 2023 05:17
Copy link

github-actions bot commented Dec 5, 2023

Test Results

   573 files  +218     573 suites  +218   3h 35m 14s ⏱️ + 1h 36m 15s
   375 tests +  14     368 ✔️ +  15    6 💤  - 1  0  - 1  1 🔥 +1 
1 125 runs  +431  1 103 ✔️ +422  19 💤 +7  0  - 1  3 🔥 +3 

For more details on these errors, see this check.

Results for commit 9b4de36. ± Comparison against base commit f943b0f.

@laeubi laeubi closed this Dec 10, 2023
@laeubi laeubi force-pushed the issue_2710_reproducer branch from 9b4de36 to 74f693b Compare December 10, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants