-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tycho-its reproducer p2Repository.downloadVerifyNoDigestAlgo (#2710) #2711
Conversation
b/tycho-its/src/test/java/org/eclipse/tycho/test/p2Repository/DownloadVerifyNoDigestAlgo.java
Outdated
Show resolved
Hide resolved
61ee82a
to
c8816bf
Compare
For some reason my new test is not picked up. Any idea why? |
I think I found the problem. Let's see whether the next build works. |
tycho-its/src/test/java/org/eclipse/tycho/test/p2Repository/DownloadVerifyNoDigestAlgoTest.java
Outdated
Show resolved
Hide resolved
OK, the test is executed now. It fails as expected:
The new integration test thus shows that Tycho currently gives the warnings that we don't want. What is the next step? |
Please squash/rebase your change so it could be uses as a basis for a possible fix. Do you maybe want to give it a try reducing the message for some of the items? At least for feature/products I think it could be a similar fix as applied for plugins already. For m2e target items it should be a bit different and reusing the maven checksums. |
6ae9154
to
3e5749f
Compare
Done.
It already took me way more time than expected to report the issue, make a minimal reproducer, and get that in the right form as a tycho-its (4+ hours). At the moment I don't have the time to actually go fixing this. Especially since I know absolutely nothing about the internals of Tycho, so it would be a huge effort to figure out where it is, what is going on, and how to address that. I was kind of hoping some Tycho developer could look at it? |
3e5749f
to
9b4de36
Compare
9b4de36
to
74f693b
Compare
My first merge request to contribute a tycho-its. Hope it works.
Addresses #2710