Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Source-Unit version when adding sources to a P2-repo #2741

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Consider Source-Unit version when adding sources to a P2-repo #2741

merged 1 commit into from
Sep 2, 2023

Conversation

HannesWell
Copy link
Member

No description provided.

@HannesWell HannesWell added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023 •
edited
Loading

Test Results

   561 files  ±0     561 suites  ±0   4h 22m 54s ⏱️ - 14m 30s
   361 tests ±0     355 ✔️ ±0    6 💤 ±0  0 ❌ ±0 
1 083 runs  ±0  1 064 ✔️ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 2ef95fa. ± Comparison against base commit eadf9b3.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell requested a review from laeubi September 2, 2023 13:33
laeubi
laeubi approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good any chance we can have an itest to verify this works (and will work in the future)?

@HannesWell
Consider Source-Unit version when adding sources to a P2-repo
2ef95fa 
And add a test case to verify the behavior is correct.
@HannesWell
Copy link
Member Author

HannesWell commented Sep 2, 2023 •
edited
Loading

any chance we can have an itest to verify this works (and will work in the future)?

Done. Extended the existing IncludeAllSourcesTest.testSourceInclusion() test case to also cover sources of artifacts with multiple versions.
I also ensured locally that the test fails without the fix and passes with it.

@HannesWell HannesWell merged commit 5e26e16 into eclipse-tycho:master Sep 2, 2023
8 checks passed
@HannesWell HannesWell deleted the sourceVersion branch September 2, 2023 16:55
@github-actions github-actions bot mentioned this pull request Sep 2, 2023
Merged
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

💚 All backports created successfully

Status Branch Result
✅ tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

Assignees
No one assigned
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannesWell @laeubi