Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assemble repository for all environments at once #2852

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Assemble repository for all environments at once #2852

merged 1 commit into from
Sep 27, 2023

Conversation

HannesWell
Copy link
Member

This is helpful for #2744 since the full resulting repository is available on the first pass.

Additionally it can improve the performance since all IUs are only processed once instead of once per environment (which applies for all IUs without environment filter) and it avoids multiplication of print-outs for each environment.

@HannesWell HannesWell added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Sep 24, 2023
@github-actions
Copy link

github-actions bot commented Sep 24, 2023 •
edited
Loading

Test Results

   561 files     561 suites   4h 35m 38s ⏱️
   363 tests    357 ✔️   6 💤 0 ❌
1 089 runs  1 070 ✔️ 19 💤 0 ❌

Results for commit 22c01cd.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Sep 25, 2023

@HannesWell some of the test now (again?) fail with

Caused by: java.lang.NoSuchMethodError: 'org.apache.maven.toolchain.java.DefaultJavaToolChain org.eclipse.tycho.core.maven.ToolchainProvider.findMatchingJavaToolChain(org.apache.maven.execution.MavenSession, java.lang.String)'

@HannesWell
Copy link
Member Author

@HannesWell some of the test now (again?) fail with

Caused by: java.lang.NoSuchMethodError: 'org.apache.maven.toolchain.java.DefaultJavaToolChain org.eclipse.tycho.core.maven.ToolchainProvider.findMatchingJavaToolChain(org.apache.maven.execution.MavenSession, java.lang.String)'

Still no clue why this happens. At least the workflows run with maven 3.9.2...

@HannesWell HannesWell force-pushed the buildReposInOnePass branch 2 times, most recently from 4aa811e to 6cb4ce8 Compare September 26, 2023 21:18
@HannesWell
Copy link
Member Author

So hopefully it is now working. At least the tests that failed in the last build now succeeded locally.
The missing pies was to copy PermissiveSlicer.isApplicable(IRequirement) so that Slicer.isApplicable(IRequirement) could be replaced too to query all environment contexts.

@HannesWell HannesWell merged commit fe7266b into eclipse-tycho:master Sep 27, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
Merged
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@HannesWell HannesWell deleted the buildReposInOnePass branch September 27, 2023 16:41
@HannesWell HannesWell mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

Assignees
No one assigned
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannesWell @laeubi