Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of output directory in packaging mojo for bundles with nested jars #2859

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix creation of output directory in packaging mojo for bundles with nested jars #2859

merged 1 commit into from
Sep 28, 2023

Conversation

jstroleny
Copy link
Contributor

@jstroleny jstroleny commented Sep 27, 2023 •
edited
Loading

Fixes #2858

@github-actions
Copy link

Test Results

   561 files  ±0     561 suites  ±0   4h 17m 19s ⏱️ -42s
   363 tests ±0     355 ✔️  - 2    6 💤 ±0  0 ❌ ±0  2 🔥 +2 
1 089 runs  ±0  1 068 ✔️  - 2  19 💤 ±0  0 ❌ ±0  2 🔥 +2 

For more details on these errors, see this check.

Results for commit 008fa21. ± Comparison against base commit 05c76bd.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Sep 28, 2023
laeubi
laeubi approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@laeubi laeubi merged commit 5118b99 into eclipse-tycho:master Sep 28, 2023
7 of 9 checks passed
@laeubi
Copy link
Member

laeubi commented Sep 28, 2023

Thnaks for providing this fix!

@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Merged
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

Assignees
No one assigned
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default lifecycle mapping for tycho packaging produces exception for bundles with nested jars
2 participants
@jstroleny @laeubi