Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 2897 #2903

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Pr 2897 #2903

merged 4 commits into from
Oct 25, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Oct 9, 2023

No description provided.

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

/request-license-review

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/6456033000

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Test Results

   564 files     564 suites   4h 33m 5s ⏱️
   368 tests    360 ✔️   6 💤 0  2 🔥
1 104 runs  1 082 ✔️ 19 💤 0  3 🔥

For more details on these errors, see this check.

Results for commit 3b97fa5.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

@akurtakov it seems https://ci.eclipse.org/tycho/job/tycho-github/job/PR-2903/1/testReport/junit/org.eclipse.tycho.test.surefire/JUnit5Test/testJUnit5Runner/ is using a very old eclipse still the test explicitly seem to reference an oxygen target but I'm not sure what it actually testing that it requires such old eclipse?

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

@akurtakov it seems https://ci.eclipse.org/tycho/job/tycho-github/job/PR-2903/1/testReport/junit/org.eclipse.tycho.test.eeProfile/CustomProfileIntegrationTest/testBuildWithCustomProfile/ is also suffering from now java.* imports not resolvable ... do you have an idea how to upgrade that test?

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

@akurtakov
Copy link
Member

No idea. Many tests just used hardcoded versions at the time they were created. In the last few years, I've been updating them (when noticed) to use the latest version where possible. This is quite time consuming.

@laeubi
Copy link
Member Author

laeubi commented Oct 9, 2023

Would you mind checking if we can update those test? I think this is independent from BND update but currently blocks the update.

@akurtakov
Copy link
Member

I'll try to find time for it.

@akurtakov
Copy link
Member

The two left will require more time than I can spend on it for now. The two remaining tests will probably need bigger changes.

@laeubi
Copy link
Member Author

laeubi commented Oct 10, 2023

Thanks at least we solved the obvious now I'm currently have no clue why the others are failing needs probably a debug session again...

@laeubi laeubi force-pushed the pr-2897 branch 2 times, most recently from 3894460 to c526e81 Compare October 22, 2023 17:49
@laeubi
Copy link
Member Author

laeubi commented Oct 22, 2023

@akurtakov I think I was able to "fix" the LocalRepositoryCrosstalkTest now ...

@laeubi
Copy link
Member Author

laeubi commented Oct 22, 2023

Hopefully CustomProfileIntegrationTest is fixed now as well...

@laeubi
Copy link
Member Author

laeubi commented Oct 23, 2023

/request-license-review

@github-actions
Copy link

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/6609406820

@laeubi
Copy link
Member Author

laeubi commented Oct 23, 2023

Build is green but we have outstanding license issues...

dependabot bot and others added 4 commits October 25, 2023 12:37
Bumps `bnd.version` from 6.4.0 to 7.0.0.

Updates `biz.aQute.bnd:biz.aQute.bndlib` from 6.4.0 to 7.0.0
- [Release notes](https://github.com/bndtools/bnd/releases)
- [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md)
- [Commits](bndtools/bnd@6.4.0...7.0.0)

Updates `biz.aQute.bnd:bnd-maven-plugin` from 6.4.0 to 7.0.0
- [Release notes](https://github.com/bndtools/bnd/releases)
- [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md)
- [Commits](bndtools/bnd@6.4.0...7.0.0)

Updates `biz.aQute.bnd:biz.aQute.repository` from 6.4.0 to 7.0.0
- [Release notes](https://github.com/bndtools/bnd/releases)
- [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md)
- [Commits](bndtools/bnd@6.4.0...7.0.0)

Updates `biz.aQute.bnd:biz.aQute.bnd.maven` from 6.4.0 to 7.0.0
- [Release notes](https://github.com/bndtools/bnd/releases)
- [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md)
- [Commits](bndtools/bnd@6.4.0...7.0.0)

Updates `biz.aQute.bnd:biz.aQute.bnd.embedded-repo` from 6.4.0 to 7.0.0
- [Release notes](https://github.com/bndtools/bnd/releases)
- [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md)
- [Commits](bndtools/bnd@6.4.0...7.0.0)

---
updated-dependencies:
- dependency-name: biz.aQute.bnd:biz.aQute.bndlib
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: biz.aQute.bnd:bnd-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: biz.aQute.bnd:biz.aQute.repository
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: biz.aQute.bnd:biz.aQute.bnd.maven
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: biz.aQute.bnd:biz.aQute.bnd.embedded-repo
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@akurtakov
Copy link
Member

Jenkins succeeded and licensecheck is fine. Merging.

@akurtakov akurtakov merged commit 69acea4 into eclipse-tycho:master Oct 25, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants