-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr 2897 #2903
Pr 2897 #2903
Conversation
/request-license-review |
License review requests:
After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
@akurtakov it seems https://ci.eclipse.org/tycho/job/tycho-github/job/PR-2903/1/testReport/junit/org.eclipse.tycho.test.surefire/JUnit5Test/testJUnit5Runner/ is using a very old eclipse still the test explicitly seem to reference an oxygen target but I'm not sure what it actually testing that it requires such old eclipse? |
@akurtakov it seems https://ci.eclipse.org/tycho/job/tycho-github/job/PR-2903/1/testReport/junit/org.eclipse.tycho.test.eeProfile/CustomProfileIntegrationTest/testBuildWithCustomProfile/ is also suffering from now |
@akurtakov https://ci.eclipse.org/tycho/job/tycho-github/job/PR-2903/1/testReport/junit/org.eclipse.tycho.test.TYCHO0367localRepositoryCrosstalk/LocalRepositoryCrosstalkTest/test/ seems another candidate that uses way too old OSGi framework... |
No idea. Many tests just used hardcoded versions at the time they were created. In the last few years, I've been updating them (when noticed) to use the latest version where possible. This is quite time consuming. |
Would you mind checking if we can update those test? I think this is independent from BND update but currently blocks the update. |
I'll try to find time for it. |
The two left will require more time than I can spend on it for now. The two remaining tests will probably need bigger changes. |
Thanks at least we solved the obvious now I'm currently have no clue why the others are failing needs probably a debug session again... |
3894460
to
c526e81
Compare
@akurtakov I think I was able to "fix" the |
Hopefully |
/request-license-review |
License review requests:
After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
Build is green but we have outstanding license issues... |
Bumps `bnd.version` from 6.4.0 to 7.0.0. Updates `biz.aQute.bnd:biz.aQute.bndlib` from 6.4.0 to 7.0.0 - [Release notes](https://github.com/bndtools/bnd/releases) - [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md) - [Commits](bndtools/bnd@6.4.0...7.0.0) Updates `biz.aQute.bnd:bnd-maven-plugin` from 6.4.0 to 7.0.0 - [Release notes](https://github.com/bndtools/bnd/releases) - [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md) - [Commits](bndtools/bnd@6.4.0...7.0.0) Updates `biz.aQute.bnd:biz.aQute.repository` from 6.4.0 to 7.0.0 - [Release notes](https://github.com/bndtools/bnd/releases) - [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md) - [Commits](bndtools/bnd@6.4.0...7.0.0) Updates `biz.aQute.bnd:biz.aQute.bnd.maven` from 6.4.0 to 7.0.0 - [Release notes](https://github.com/bndtools/bnd/releases) - [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md) - [Commits](bndtools/bnd@6.4.0...7.0.0) Updates `biz.aQute.bnd:biz.aQute.bnd.embedded-repo` from 6.4.0 to 7.0.0 - [Release notes](https://github.com/bndtools/bnd/releases) - [Changelog](https://github.com/bndtools/bnd/blob/master/docs/ADDING_RELEASE_DOCS.md) - [Commits](bndtools/bnd@6.4.0...7.0.0) --- updated-dependencies: - dependency-name: biz.aQute.bnd:biz.aQute.bndlib dependency-type: direct:production update-type: version-update:semver-major - dependency-name: biz.aQute.bnd:bnd-maven-plugin dependency-type: direct:production update-type: version-update:semver-major - dependency-name: biz.aQute.bnd:biz.aQute.repository dependency-type: direct:production update-type: version-update:semver-major - dependency-name: biz.aQute.bnd:biz.aQute.bnd.maven dependency-type: direct:production update-type: version-update:semver-major - dependency-name: biz.aQute.bnd:biz.aQute.bnd.embedded-repo dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Jenkins succeeded and licensecheck is fine. Merging. |
No description provided.