Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select best matching target environment for p2install #3088

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Nov 24, 2023

Currently a p2 provisioned install always use the running target to provision what is also the best option most of the time. In case where there is no matching one this can lead to failing installs.

This now allows to specify the environments and shows a warning if the running one does not has any match.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Nov 24, 2023
@laeubi laeubi force-pushed the select_the_best_matching_environment_for_p2_provisioned_install branch 2 times, most recently from 4902ce0 to 46d4a80 Compare November 24, 2023 16:39
Currently a p2 provisioned install always use the running target to
provision what is also the best option most of the time. In case where
there is no matching one this can lead to failing installs.

This now allows to specify the environments and shows a warning if the
running one does not has any match.
@laeubi laeubi force-pushed the select_the_best_matching_environment_for_p2_provisioned_install branch from 46d4a80 to 0386634 Compare November 24, 2023 16:49
@laeubi
Copy link
Member Author

laeubi commented Nov 24, 2023

/request-license-review

Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/6983406284

Copy link

Test Results

   570 files  ±0     570 suites  ±0   3h 35m 56s ⏱️ + 6m 31s
   374 tests ±0     368 ✔️ ±0    6 💤 ±0  0 ±0 
1 122 runs  ±0  1 103 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 0386634. ± Comparison against base commit a6dfcba.

@laeubi laeubi merged commit 3f41779 into eclipse-tycho:master Nov 24, 2023
9 of 10 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant