Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deployableFeature option #3089

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Nov 24, 2023

The deployableFeature option will create "standard eclipse update site directory with feature content will be created under target folder" but we already removed site-packaging from tycho for a while, if one wants to archive similar a category.xml with eclipse-repository packaging gives much more control and power to the user.

This also free us from one reference to ArtifactDependencyWalker, so only one reference left in BuildQualifierAggregatorMojo before we can remove that completely.

requires:

@laeubi laeubi force-pushed the remove_deployableFeature branch 2 times, most recently from 0f99be6 to 41cb4fb Compare November 24, 2023 17:11
Copy link

github-actions bot commented Nov 24, 2023

Test Results

  576 files  ±0    576 suites  ±0   3h 29m 49s ⏱️ + 7m 16s
  380 tests ±0    373 ✅  - 1   7 💤 +1  0 ❌ ±0 
1 140 runs  ±0  1 118 ✅  - 3  22 💤 +3  0 ❌ ±0 

Results for commit 49e0c52. ± Comparison against base commit 963075e.

This pull request skips 1 test.
org.eclipse.tycho.test.TYCHO321deployableFeature.DeployableFeatureTest ‑ testDeployableFeature

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the remove_deployableFeature branch from 41cb4fb to 7c94b82 Compare November 24, 2023 18:59
@laeubi laeubi added this to the 5.0 milestone Nov 25, 2023
@laeubi laeubi force-pushed the remove_deployableFeature branch from 7c94b82 to 8667eb2 Compare January 7, 2024 16:02
The deployableFeature option will create "standard eclipse update site
directory with feature content will be created under target folder" but
we already removed site-packaging from tycho for a while, if one wants
to archive similar a category.xml with eclipse-repository packaging
gives much more control and power to the user.
@laeubi laeubi force-pushed the remove_deployableFeature branch from 8667eb2 to 49e0c52 Compare January 7, 2024 16:04
@laeubi laeubi merged commit c5ff94b into eclipse-tycho:main Jan 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant