Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple circular requirement that should be properly filtered #3227

Closed
wants to merge 1 commit into from

Conversation

merks
Copy link
Contributor

@merks merks commented Dec 11, 2023

@merks
Copy link
Contributor Author

merks commented Dec 11, 2023

This fails like this for me in a terminal window:

[ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='tycho-its-project.p2Inf.circular:circular.bundle2:1.0.0-SNAPSHOT'}' and 'Vertex{label='tycho-its-project.p2Inf.circular:circular.bundle1:1.0.0-SNAPSHOT'}' introduces to cycle in the graph tycho-its-project.p2Inf.circular:circular.bundle1:1.0.0-SNAPSHOT --> tycho-i
ts-project.p2Inf.circular:circular.bundle2:1.0.0-SNAPSHOT --> tycho-its-project.p2Inf.circular:circular.bundle1:1.0.0-SNAPSHOT @
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='tycho-its-project.p2Inf.circular:circular.bundle2:1.0.0-SNAPSHOT'}' and 'Vertex{label='tycho-its-project.p2Inf.circular:circular.bundle1:1.0.0-SNAPSHOT'}' introduces to cycle in the graph tycho-its-project.p2Inf.circular:circular.bundle1:1.0.0-SNAPSHOT --> tycho-its-proje
ct.p2Inf.circular:circular.bundle2:1.0.0-SNAPSHOT --> tycho-its-project.p2Inf.circular:circular.bundle1:1.0.0-SNAPSHOT -> [Help 1]
[ERROR]

I think this is the most trivial case of a requirement that should be filtered during the build...

Copy link

Test Results

   576 files  +3     576 suites  +3   3h 50m 3s ⏱️ - 8m 44s
   378 tests +1     371 ✔️ ±0    6 💤 ±0  0 ±0  1 🔥 +1 
1 134 runs  +3  1 112 ✔️ ±0  19 💤 ±0  0 ±0  3 🔥 +3 

For more details on these errors, see this check.

Results for commit 9f482ee. ± Comparison against base commit 005f96b.

@merks
Copy link
Contributor Author

merks commented Dec 11, 2023

@laeubi
Copy link
Member

laeubi commented Dec 16, 2023

This is now integrated in the main an Tycho 4 branch, thanks for the test-case.

@laeubi laeubi closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants