Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document (better) referencedRepositoryMode in TargetPlatformConfigura… #3229

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

LorenzoBettini
Copy link
Contributor

…tionMojo.java

This should hopefully improve the documentation of referencedRepositoryMode (it was not clear to me which values to specify)

…tionMojo.java

This should hopefully improve the documentation of referencedRepositoryMode (it was not clear to me which values to specify)
@laeubi
Copy link
Member

laeubi commented Dec 11, 2023

@LorenzoBettini as you seem to using that option already it is currently off by default, but maybe you thing we should make it on by default for Tycho 5?

@LorenzoBettini
Copy link
Contributor Author

@laeubi since PDE automatically uses referenced repositories I think it would be a good idea to enable it by default, if you ask me :)

In fact, my target platform was resolving correctly in PDE, while it was failing in the Tycho build (I'm using Epsilon, whose update site refers to older Orbit sites for its dependencies, I noted this problem when updating my target platform to newer Eclipse/Orbit). Luckily, I've discovered this new cool feature of Tycho, enabled it, and everything works like a charm.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Dec 11, 2023
@laeubi laeubi merged commit 0842d26 into eclipse-tycho:master Dec 11, 2023
9 of 10 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@laeubi
Copy link
Member

laeubi commented Dec 11, 2023

@laeubi since PDE automatically uses referenced repositories I think it would be a good idea to enable it by default, if you ask me :)

Do you want to open a PR + a note to the release notes that this is now the default and reference how to restore old behavior for Tycho 5 here?

@LorenzoBettini
Copy link
Contributor Author

@laeubi OK. So, if I understand correctly in that PR I should make include the default (I seem to understand it is enough to make that element the first one in the enum), change the Javadoc accordingly and update the release notes for 5 accordingly (of course, I guess also a few IT will have to be updated). Is that correct?

@laeubi
Copy link
Member

laeubi commented Dec 11, 2023

I should make include the default (I seem to understand it is enough to make that element the first one in the enum)

Correct, you might to verify with a local build that the default is taken into account

change the Javadoc accordingly and update the release notes for 5 accordingly

Yep

I guess also a few IT will have to be updated

I hope not, but some might fail and then should simply use the old "default" value then, I think we have no real IT to actually test the feature itself so if you like to add one it would of course also be great :-)

Is that correct?

Would really be appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants