Disable P2 mirrors by default #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 576 files ±0 576 suites ±0 3h 23m 16s ⏱️ - 50m 34s For more details on these failures, see this check. Results for commit d318c83. ± Comparison against base commit bd2796d. ♻️ This comment has been updated with latest results. |
Having p2 mirrors enabled has some drawbacks as it can lead to instabilities see eclipse-equinox/p2#414 also test can fail because a mirror can't be reached or is slow. Because of this we should disable mirrors all together and only selectively enable them for tests where this is required.
laeubi
force-pushed
the
disable_mirrors
branch
from
1cb129d to
d318c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having p2 mirrors enabled has some drawbacks as it can lead to instabilities see eclipse-equinox/p2#414 also test can fail because a mirror can't be reached or is slow.
Because of this we should disable mirrors all together and only selectively enable them for tests where this is required.