Restoring the option to ignore p2 mirrors via the Maven settings

[vogella]

Commit 7e6d595 has removed the option to use the settings.xml to disable the usage of p2 mirrors.

See https://github.com/eclipse-tycho/tycho/wiki/Frequently-asked-questions#how-do-i-disable-p2-mirrors

Restores this option and give the command line option priority.

[laeubi]

Please use eclipse.p2.mirrors property instead here.

Also it seems your are working on an outdated master branch.

[vogella]

Please use eclipse.p2.mirrors property instead here.

eclipse.p2.mirrors is the new tycho.disableP2Mirrors? Do we want to support both or only the latest? Shall I also update the FAQ? https://github.com/eclipse-tycho/tycho/wiki/Frequently-asked-questions#how-do-i-disable-p2-mirrors

Also it seems your are working on an outdated master branch.

Ah, you moved to main, will update

[github-actions]

Test Results

  579 files  ±0    579 suites  ±0   3h 50m 28s ⏱️ + 6m 31s
  383 tests ±0    376 ✅ +1   7 💤 ±0  0 ❌  - 1 
1 149 runs  ±0  1 127 ✅ +1  22 💤 ±0  0 ❌  - 1 

Results for commit ca5ea44. ± Comparison against base commit 1f99d2d.

♻️ This comment has been updated with latest results.

[laeubi]

@vogella the next bugfix release will happen at end of this month, do you plan to finish your work here so it can be included?

[vogella]

Looking into it now

[vogella]

@vogella the next bugfix release will happen at end of this month, do you plan to finish your work here so it can be included?

Thanks for the ping and happy new year to you.

[laeubi]

I think there should be a method that encapsulates the retrival of a property, the both code pathes manly differ in the property name used, so something like:

String deprecatedValue = getMirrorProperty("tycho.disableP2Mirrors");
String newValue = getMirrorProperty("eclipse.p2.mirrors");

currently the logic for both properties is duplicated what makes it hard to follwo what happens and to check for the fallbacks (e.g. session)

[laeubi]

@vogella can you make sure the pom.xml change is reverted and apply the suggestions, it seems usefull to include this in the enxt bugfix release.

[vogella]

Is tomorrow timing-wise ok? Today I'm working outside Eclipse world

[laeubi]

Yes we still have some days until release, I just don'T want to delay it forever as theres always something new :-D

[vogella]

I updated the change

[laeubi]

Looks good now and build is green.

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details