Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions if the project references another pom as module #3343

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update versions if the project references another pom as module #3343

merged 1 commit into from
Jan 10, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 10, 2024 •
edited
Loading

  • create a testcase
  • fix the issue

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Test Results

  576 files  ±0    576 suites  ±0   4h 1m 17s ⏱️ + 19m 7s
  381 tests +1    373 ✅ +1   7 💤 ±0  1 ❌ ±0 
1 143 runs  +3  1 120 ✅ +3  22 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 77ad7cd. ± Comparison against base commit 86db29d.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the issue_3341_version_update_nested branch 4 times, most recently from 220a200 to 53da5a8 Compare January 10, 2024 10:33
@laeubi laeubi added the sponsored The bugfix or feature was gently sponsored by an individual or company label Jan 10, 2024
@laeubi laeubi marked this pull request as ready for review January 10, 2024 10:34
@laeubi laeubi force-pushed the issue_3341_version_update_nested branch 2 times, most recently from 9008e90 to 50864c6 Compare January 10, 2024 10:42
@laeubi laeubi linked an issue Jan 10, 2024 that may be closed by this pull request
[tycho-version-plugin] only current project version is updated when project references another pom #3341
Closed
@laeubi laeubi force-pushed the issue_3341_version_update_nested branch from 50864c6 to d21d736 Compare January 10, 2024 12:55
@laeubi laeubi force-pushed the issue_3341_version_update_nested branch from d21d736 to 77ad7cd Compare January 10, 2024 12:56
@laeubi laeubi merged commit f5968e4 into eclipse-tycho:main Jan 10, 2024
8 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
@github-actions GitHub Actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@sratz sratz mentioned this pull request May 3, 2024
Closed
sratz added a commit to sratz/tycho that referenced this pull request May 8, 2024
@sratz
set-version: Fix regression overwriting mismatching versions
ebcb491 
Fix regression introduced in eclipse-tycho#3343.

Also for the child modules the version of the change must match, so that
it does not blindly overwrite the versions of the submodules.

Fixes eclipse-tycho#3808.
@sratz sratz mentioned this pull request May 8, 2024
Merged
laeubi pushed a commit that referenced this pull request May 8, 2024
@sratz @laeubi
set-version: Fix regression overwriting mismatching versions
8cb0cc7 
Fix regression introduced in #3343.

Also for the child modules the version of the change must match, so that
it does not blindly overwrite the versions of the submodules.

Fixes #3808.
eclipse-tycho-bot pushed a commit that referenced this pull request May 8, 2024
@sratz
set-version: Fix regression overwriting mismatching versions
5596185 
Fix regression introduced in #3343.

Also for the child modules the version of the change must match, so that
it does not blindly overwrite the versions of the submodules.

Fixes #3808.

(cherry picked from commit 8cb0cc7)
eclipse-tycho-bot pushed a commit that referenced this pull request May 8, 2024
@sratz @eclipse-tycho-bot
set-version: Fix regression overwriting mismatching versions
749723c 
Fix regression introduced in #3343.

Also for the child modules the version of the change must match, so that
it does not blindly overwrite the versions of the submodules.

Fixes #3808.

(cherry picked from commit 8cb0cc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change sponsored The bugfix or feature was gently sponsored by an individual or company
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tycho-version-plugin] only current project version is updated when project references another pom
1 participant
@laeubi