Enable JUnit 5 test suite engine in tycho-surefire #2462 #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
issue-2462
branch
from
50b0a0d to
731e5d7
Compare
laeubi
added
the
backport-to-tycho-4.0.x
Currently, Tycho is not capable of running JUnit 5 test suites, since the required SuiteTestEngine is not provided while running tests. This change adds the SuiteTestEngine to tycho-surefire executions using JUnit Platform 1.8 (the first with suite support) or newer. To this end, the SuiteTestEngine is always enabled when running JUnit 5 tests. It also adds a regression test for executing a test suite based on JUnit Jupiter 5.9. Fixes eclipse-tycho#2462
HeikoKlare
force-pushed
the
issue-2462
branch
from
731e5d7 to
a842a10
Compare
laeubi
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
@akurtakov It looks al sane to me, but as you have done the surefire parts in the past you probably want to take a second look.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
Thank you for reviewing and merging this so fast, @laeubi and @akurtakov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Tycho is not capable of running JUnit 5 test suites, since the required
SuiteTestEngineis not provided while running tests.This change adds the
SuiteTestEngineto tycho-surefire executions using JUnit Platform 1.8 (the first with suite support) or newer. To this end, theSuiteTestEngineis always enabled when running JUnit 5 tests. It also adds a regression test for executing a test suite based on JUnit Jupiter 5.9.I do not see any problems of simply making the
SuiteTestEnginealways available (other than theVintageTestEngine), but let me know if you think different. The problem when adding further fragments likejunit59withvintagefor when the suite API is on the classpath is the combinatorial complexity, as you would needjunitX,junitXwithvintage,junitXwithsuite,junitXwithsuiteandvintage.Fixes #2462
Closes #3342