Add support for platform URLs in automatic manifest generation plugins #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
laeubi
force-pushed
the
platform_url_in_bnd
branch
2 times, most recently
from
24952ef to
acb71db
Compare
PDE allows the definition of extraClassPathJars what is very similar to bnd -classpath, one usually uses a platform:/<reference to project>/<somejar>. Currently there are two issues: 1) the tycho-compile does not understand these 2) bnd tries to resolve them with httpclient This adds the code to correctly resolve them in a similar way as Tycho does for extraClassPathJars.
laeubi
force-pushed
the
platform_url_in_bnd
branch
from
acb71db to
7c57bbc
Compare
Test Results 579 files ±0 579 suites ±0 3h 55m 54s ⏱️ + 11m 57s For more details on these failures, see this check. Results for commit 7c57bbc. ± Comparison against base commit 1f99d2d. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDE allows the definition of extraClassPathJars what is very similar to bnd -classpath, one usually uses a platform://. Currently there are two issues:
This adds the code to correctly resolve them in a similar way as Tycho does for extraClassPathJars.