Authentication fails when trying to resolve a target platform over an authenticated mirror that is a composite repository #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevloral
force-pushed
the
auth_composite_mirror
branch
2 times, most recently
from
bb05a8d to
4e4df3d
Compare
kevloral
force-pushed
the
auth_composite_mirror
branch
from
3eebbca to
df0fd65
Compare
|
The problem lied in the fact that RemoteMetadataRepositoryManager was passing the original location to the MavenAuthenticator, instead of the effective one: On the other hand, RemoteArtifactRepositoryManager was already passing the effective URI instead of the original one, so no change was needed there: |
laeubi
approved these changes
Mar 18, 2024
| @@ -63,7 +63,7 @@ public IMetadataRepository loadRepository(URI location, IProgressMonitor monitor | |||
| public IMetadataRepository loadRepository(URI location, int flags, IProgressMonitor monitor) | |||
| throws ProvisionException, OperationCanceledException { | |||
| URI effectiveLocation = translateAndPrepareLoad(location); | |||
| authenticator.enterLoad(location); | |||
| authenticator.enterLoad(effectiveLocation); | |||
laeubi
added
the
backport-to-tycho-4.0.x
RemoteMetadataRepositoryManager now passes the effective URI to the MavenAuthenticator instead of the original one. This fixes eclipse-tycho#3501. This commit also includes the test that was used to reproduce the bug: - testTargetDefinitionAuthMirror: tries to resolve a target definition from a composite p2 repository accessed over an authenticated composite mirror. Also, several other tests have been created just for completion: - testAuthMirror: tries to access a composite p2 repository over an authenticated composite mirror. - testMirror: tries to access a composite p2 repository over a composite mirror with no authentication. - testRepositoryEncrypted: tries to access an authenticated composite p2 repository whose password is encrypted. - testTargetDefinition: tries to resolve a target platform from a composite p2 repository. - testTargetDefinitionEncrypted: tries to resolve a target definition from an authenticated composite p2 repository whose password is encrypted. - testTargetDefinitionMirror: tries to resolve a target definition from a composite p2 repository accessed over a composite mirror with no authentication.
laeubi
force-pushed
the
auth_composite_mirror
branch
from
df0fd65 to
2c51b36
Compare
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test created for reproducing the bug as described in #3501:
On the other hand, the following tests pass and have been created just for completion: