Extend demo bnd-workspace with subbundles #4661
Open
+105
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
Jan 30, 2025
...e/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/impl/MarkdownRendererImpl.java
Show resolved
Hide resolved
...kspace/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/api/MarkdownRenderer.java
Show resolved
Hide resolved
chrisrueger
force-pushed
the
extend-demo-bndworkspace-with-subbundles
branch
from
de5eba7 to
9cb9035
Compare
laeubi
reviewed
Jan 31, 2025
...e/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/impl/MarkdownRendererImpl.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
Jan 31, 2025
...kspace/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/api/MarkdownRenderer.java
Outdated
Show resolved
Hide resolved
chrisrueger
force-pushed
the
extend-demo-bndworkspace-with-subbundles
branch
from
638c519 to
641e7d0
Compare
laeubi
reviewed
Jan 31, 2025
laeubi
reviewed
Jan 31, 2025
bump tycho version to 4.0.10 gitignore MacOS .DS_Store files add bundle using bnd's sub-bundles via -sub: *.bnd see the bnd.bnd of the new tycho.demo.markdown bundle. it uses the -sub: *.bnd instruction to create 2 jar files based on the other .bnd files (api.bnd and impl.bnd) this build currently fails and we want to use that to fix tycho to make it pass. It seems that tycho currently does not recognize the 2 (sub) jars so it cannot find them as dependencies for the HelloWorldService [ERROR] Failed to execute goal org.eclipse.tycho:tycho-bnd-plugin:4.0.10:compile (compile) on project tycho.demo.impl: javac failed /bnd-workspace/tycho.demo.impl/src/main/java/org/eclipse/tycho/demo/impl/HelloWorldService.java:18: error: package tycho.demo.utils.markdown.api does not exist [ERROR] import tycho.demo.utils.markdown.api.MarkdownRenderer; [ERROR] ^ [ERROR] /bnd-workspace/tycho.demo.impl/src/main/java/org/eclipse/tycho/demo/impl/HelloWorldService.java:24: error: cannot find symbol [ERROR] private MarkdownRenderer markdown; [ERROR] ^ [ERROR] symbol: class MarkdownRenderer [ERROR] location: class HelloWorldService [ERROR] 2 errors add licence headers Update demo/bnd-workspace/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/impl/MarkdownRendererImpl.java Update demo/bnd-workspace/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/api/MarkdownRenderer.java Update demo/bnd-workspace/tycho.demo.markdown/api.bnd Co-Authored-By: Christoph Läubrich <[email protected]>
chrisrueger
force-pushed
the
extend-demo-bndworkspace-with-subbundles
branch
from
32d9b76 to
41ce326
Compare
laeubi
added
the
backport-to-tycho-4.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the
bnd.bndof the newtycho.demo.markdownbundle.it uses the
-sub: *.bndinstruction to create 2 jar files based on the other .bnd files (api.bnd and impl.bnd)this build currently fails (which is intentional) and we want to use that to fix tycho to make it compile.
It seems that tycho currently does not recognize the 2 (sub) jars so it cannot find them as dependencies for the HelloWorldService
Expected result
The build should have produced two jars in
tycho.demo.markdownAnd those should be recognized as dependency as required by the
-buildpathof thetycho.demo.impl/bnd.bnd, so thattycho.demo.implcompiles successfully.