Update license check, version and pre-commit

[erikbosch]

Previously both gave warnings.

• Pre-commit as using Node.js 16
• License check as error code was presented

Fixes #58
Fixes #57

Changes tested (for python app) on this repo https://github.com/erikbosch/vehicle-example-app2

Example pre-commit

• Previous build: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9464628807
• New build: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9513024768

Warning only present in old build

Run unit tests and linters
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Example License check

• Old run: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9464326913
• New run: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9513024770

Old run gave warning. In new run dash output is presented.

Old:

Check Software Licenses
Process completed with exit code 23.

New:

[main] INFO Querying Eclipse Foundation for license data for 79 items.
[main] INFO Found 23 items.
[main] INFO Querying ClearlyDefined for license data for 57 items.
[main] INFO Found 57 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO git/github/actions/download-artifact/v4
[main] INFO git/github/actions/setup-java/v4
[main] INFO git/github/actions/setup-node/v4
[main] INFO git/github/actions/setup-python/v5
[main] INFO git/github/actions/upload-artifact/v4
[main] INFO git/github/aquasecurity/trivy-action/0.19.0
[main] INFO git/github/dawidd6/action-download-artifact/v3
[main] INFO git/github/docker/build-push-action/v5
[main] INFO git/github/docker/setup-buildx-action/v3
[main] INFO git/github/docker/setup-qemu-action/v3
[main] INFO git/github/fountainhead/action-wait-for-check/v1.2.0
[main] INFO git/github/mikepenz/action-junit-report/v4
[main] INFO git/github/softprops/action-gh-release/v2
[main] INFO pypi/pypi/-/coverage/7.3.2
[main] INFO pypi/pypi/-/exceptiongroup/1.1.3
[main] INFO pypi/pypi/-/grpcio/1.59.0
[main] INFO pypi/pypi/-/mypy/1.5.1
[main] INFO pypi/pypi/-/paho-mqtt/1.6.1
[main] INFO pypi/pypi/-/parameterized/0.9.0
[main] INFO pypi/pypi/-/setuptools/58.1.0
[main] INFO pypi/pypi/-/typing-extensions/4.11.0
[main] INFO pypi/pypi/-/velocitas-sdk/0.14.1
[main] INFO pypi/pypi/-/wheel/0.41.2
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

Changes inspired by what exist in https://github.com/eclipse-kuksa/kuksa-actions/tree/main/check-dash. If a token is available then one could consider supporting automatic review requests as well.

Example Battila7

Previously we got warnings like:

Updated code tested with tags of type v0.0.4, 0.0.5 and tarzan. See results at https://github.com/erikbosch/vehicle-example-app2/pkgs/container/vehicle-example-app2%2Fsampleapp

[erikbosch]

Here we go again, two more ideas to get rid of warnings. Tested only on Python app, but have difficulties seeing that this should give problems for cpp/sdks

[MP91]

We also have the VELOCITAS_PROJECT_TOKEN which should do the stuff for dash

[erikbosch]

We also have the VELOCITAS_PROJECT_TOKEN which should do the stuff for dash

You mean to request a review, similar to how we use secrets.ECLIPSE_GITLAB_API_TOKEN in for example Databroker. I think that makes sense, but should we do it in this PR?

      - name: Dash license check
        uses: eclipse-kuksa/kuksa-actions/check-dash@4
        with:
          dashinput: ${{github.workspace}}/dash-databroker-deps
          dashtoken: ${{ secrets.ECLIPSE_GITLAB_API_TOKEN }}

[MP91]

lgtm