Fix #295

[cvgaviao]

Signed-off-by: Cristiano V. Gavião [email protected]

Motivation:
Allows the developer to have enum in their data classes that need to convert from and to JSON.
#295

[vietj]

can you remove those extra commits for NPE so we can review only the new feature and then we will examine the commits that fix potential NPE

[cvgaviao]

can you remove those extra commits for NPE so we can review only the new feature and then we will examine the commits that fix potential NPE

done

[vietj]

it should be renamed with XXXWithCustomFactory because constructor has a very specific meaning

[cvgaviao]

ok, I did the required changes... :D

But it is really called an enum constructor, not a factory :)
Look here: https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html

[vietj]

DataObjectWithMappedEnum

[vietj]

A couple comments have been made to rename things more consistently.

[vietj]

I think we need also then to update the index.adoc and the @README` files to somehow say that now enums can be seen as data object when convenient, i.e when the code generator might want to look at this from this perspective.

[vietj]

@cvgaviao can you update the index.adoc and readme files with the changes brought the to model ?

[Fyro-Ing]

How can we help to get this feature ?
we could use it with swagger-codegen (after adding a vertx module to generate with @dataobject on project) to have a full OpenAPI contracts compliance & use service proxies or new web api service

[vietj]

this PR is missing update to documentation as said in my last comment, if you can contribute it it is fine

[Fyro-Ing]

Update files here Fyro-Ing@1939916

if @cvgaviao can't merge in few days, i'll do a PR directly

Note : Readme updated to conform with json-mappers.properties, not @Mapper

[vietj]

thanks!

…

On Mon, Sep 13, 2021 at 6:39 PM Fyro ***@***.***> wrote: Update files here ***@***.*** <Fyro-Ing@1939916> if @cvgaviao <https://github.com/cvgaviao> can't merge in few days, i'll do a PR directly Note : Readme updated to conform with json-mappers.properties, not @Mapper — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#325 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXDCTI3FHAOGPF5P7KBSTUBYSMRANCNFSM4ZJFYOSQ> .

[cvgaviao]

@Fyro-Ing, you can do that. ;)
I'm not using vert.x in my new job, and the company that I did this PR for also stopped using it.

Update files here Fyro-Ing@1939916

if @cvgaviao can't merge in few days, i'll do a PR directly

Note : Readme updated to conform with json-mappers.properties, not @Mapper

[Fyro-Ing]

new PR #341

[vietj]

merged with new PR.