Discriminator support for oneOf schema #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dps123
force-pushed
the
discriminator
branch
from
4638960 to
eeba4ae
Compare
Signed-off-by: Pavel Demenkov <[email protected]>
dps123
force-pushed
the
discriminator
branch
from
eeba4ae to
98c0ab6
Compare
src/main/java/io/vertx/ext/json/schema/common/OneOfValidatorFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pavel Demenkov <[email protected]>
dps123
force-pushed
the
discriminator
branch
from
98c0ab6 to
ffb7182
Compare
Signed-off-by: Pavel Demenkov <[email protected]>
Signed-off-by: Pavel Demenkov <[email protected]>
| } | ||
| } | ||
|
|
||
| private boolean checkDiscriminator(SchemaInternal schema, Object in) { |
There was a problem hiding this comment.
I'm wondering, can we place some of this code that parses the original schema in the factory/initialization code more than on the hot path?
You can also reorganize the data structure of the validator to have a map discriminator -> schema. Note that you don't have to use the same validator both for oneOf case and oneOf + discriminator case. Feel free to reach me if you have more questions
There was a problem hiding this comment.
@slinkydeveloper Moved the schema parsing to the validator initializer
There was a problem hiding this comment.
Can you please check my comments on #31?
|
Links to #31 |
# Conflicts: # src/main/java/io/vertx/json/schema/openapi3/OneOfDiscriminatorValidatorFactory.java
Signed-off-by: Pavel Demenkov <[email protected]>
murakobardenas
approved these changes
Mar 26, 2021
|
We have deprecated this API and the new one does not uses this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Demenkov [email protected]