Introduce a pool builder to replace static pool methods #1354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
SqlConnectOptions
do not extend anymoreNetClientOptions
and user should be able to configure it which would clutter the current static methodsPool
sub types as they don't declare any methodsDeprecations
For removal in a subsequent PR
Pool
subclasses, e.gPgPool
Pool#connectHandler
andPool#connectionProvider
Proposal
A builder class takes an driver instance and build the client according to its state.
An alternative pattern for the builder API is also provided: