-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lw/static lib #812
Lw/static lib #812
Conversation
Server mode is enabled, if no mode (client, server or bootstrap-server) is selected. A warning is submitted to inform the user of Wakaama about the default. This simplifies testing and CI.
93e8851
to
8beee7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be beneficial to have your clarifying comments to my concerns to be stored in the Git commit messages and/or as comments in the sources.
But I am not insisting on this and therefore approving the PR.
8beee7a
to
e20fcc9
Compare
The CI build script now supports a flag to provide a custom build directory.
The static library can be configured with CMake variables and then be linked to user applications. Wakaama became difficult to build and to maintain. Among other things, there are defines and compiler flags that have to be set, the right set of source files need to be selected and the correct include directories have to be provided. Therefore we rely on CMake and provide the users of Wakaama a static library, which is relatively simple to build with a given set of requested features. This also helps with modularizing Wakaama to improve maintainability.
e20fcc9
to
33e5b13
Compare
|
It might be worthwhile to give some instructions in the readme on how to build and use the static library. |
I was thinking about introducing small tutorials on how to implement small applications with Wakaama. But I didn't have the resources to do that, yet. |
Create a static library for Wakaama.