fix: more consistent cli #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary parameters
Hennzau
force-pushed
the
fix/consistent_cli
branch
from
8f9c703 to
2e94555
Compare
J-Loudet
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks for your contribution, zfctl is looking better & better! 😉
There are few occurrences of the word runtime that remain, as indicated in my comments. There are also others in some strings in the zfctl/src/utils.rs file. If you can address these, the PR will be good to merge.
|
Yep I didn't catch them all the first time! thx |
Hennzau
force-pushed
the
fix/consistent_cli
branch
2 times, most recently
from
b5b7331 to
960fc29
Compare
Hennzau
force-pushed
the
fix/consistent_cli
branch
from
960fc29 to
59430ff
Compare
J-Loudet
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves consistency within the CLI:
runtimehas been replaced withdaemonin most comments, ensuring users interact only with the concept of adaemon.zenoh-configurationparameters have been removed.run-localcommand has been moved to a separate file and is now used the same way asdaemonandinstancecommands.