-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't tag dry-run releases #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
force-pushed
the
no-tag-in-dry-run
branch
from
October 23, 2024 13:48
d0f3cec
to
4ff1020
Compare
The diff is large likely because #238 hasn't been merged yet and my |
diogomatsubara
approved these changes
Oct 23, 2024
fuzzypixelz
force-pushed
the
no-tag-in-dry-run
branch
from
October 23, 2024 14:26
4ff1020
to
2070774
Compare
diogomatsubara
added a commit
to ZettaScaleLabs/zenoh-python
that referenced
this pull request
Nov 14, 2024
Aligning with [ci repository](eclipse-zenoh/ci#239) to not tag the repo when we are running release dry-run
diogomatsubara
added a commit
to ZettaScaleLabs/zenoh-kotlin
that referenced
this pull request
Nov 14, 2024
Aligning with [ci repository](eclipse-zenoh/ci#239) to not tag the repo when we are running release dry-run
diogomatsubara
added a commit
to ZettaScaleLabs/zenoh-java
that referenced
this pull request
Nov 14, 2024
Aligning with [ci repository](eclipse-zenoh/ci#239) to not tag the repo when we are running release dry-run
Mallets
pushed a commit
to eclipse-zenoh/zenoh-python
that referenced
this pull request
Nov 14, 2024
Aligning with [ci repository](eclipse-zenoh/ci#239) to not tag the repo when we are running release dry-run
Mallets
pushed a commit
to eclipse-zenoh/zenoh-kotlin
that referenced
this pull request
Nov 14, 2024
Aligning with [ci repository](eclipse-zenoh/ci#239) to not tag the repo when we are running release dry-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the eclipse-zenoh/zenoh release workflow. Bindings have their own bump-and-tag.bash scripts which would need to updated individually.