Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -llibzenohc in generated zenohc.pc #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valgur
Copy link

@valgur valgur commented Apr 4, 2024

Removes the invalid lib prefix from the library name.

The generated zenohc.pc currently looks like:

prefix=/home/martin/.conan2/p/b/zenoh51dc992dc8130/p

Name: zenohc
Description: The C bindings for Zenoh
URL: https://github.com/eclipse-zenoh/zenoh-c
Version: 0.10.1.1
Cflags: -I${prefix}/include
Libs: -L${prefix}/lib -llibzenohc

Remove the invalid `lib` prefix from the library name.
@eclipse-zenoh-bot
Copy link
Contributor

@valgur If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@valgur
Copy link
Author

valgur commented Apr 4, 2024

I signed the ECA.

@valgur
Copy link
Author

valgur commented Apr 5, 2024

Also, install(FILES ${dylib_path} DESTINATION ${CMAKE_INSTALL_LIBDIR} CONFIGURATIONS ${configurations}) should point to bin/ on Windows instead of lib/ for Windows.

@traversaro
Copy link
Contributor

Also, install(FILES ${dylib_path} DESTINATION ${CMAKE_INSTALL_LIBDIR} CONFIGURATIONS ${configurations}) should point to bin/ on Windows instead of lib/ for Windows.

Modification proposed in #471 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants