Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zenoh-c-from-source Conan recipe #336

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

oteffahi
Copy link
Contributor

@oteffahi oteffahi commented Apr 16, 2024

This PR adds a conan recipe that builds Zenoh-C from source.

Specifically, this recipe builds a zenoh-c version (currently only 0.10.1-rc) from source using Rust compiler and cmake.

Note: The recipe assumes the appropriate Rust toolchain version is installed on the host (1.72.0 in case of 0.10.1-rc)

Copy link

@gregmedd gregmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me. I was able to build another conan package (up-zenoh-client-cpp) using zenohc/0.10.1-rc as a dependency.

Comment on lines +1 to +4
sources:
"0.10.1-rc":
url: "https://github.com/eclipse-zenoh/zenoh-c/archive/refs/tags/0.10.1-rc.tar.gz"
sha256: "9fb703eff79b7c1ef216f411dadcb7f0132c8ba665823b5a8252b467b4937438"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very experienced with conan packaging, so forgive me if the answer to this is obvious: Is there a way to build whatever is currently checked out in the git repo? There may be times where we want to test downstream projects using a specific commit of zenoh-c.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregmedd it is possible to have a recipe that checks out a specific commit. However it would require a different logic for the "source" function. Another challenge to take into account is the expected Rust version which can vary between commits.
Finally, this feature breaks CCI's recipe rule about only supporting stable releases in the recipes. But I guess we're already past that point 😅

Is this something you would like to see in this recipe?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oteffahi That makes sense. Let's keep this recipe as is - better to have something that is correct and in line with what CCI would want, even this can't be submitted there yet. If we do ever find a need to build a development package, we'll figure out how to do it then.

Feel free to mark this comment resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregmedd We've experimented with compiling specific commits, and it seems pretty straight-forward to add. As far as I know this not in-line with CCI's recipe requirements, but since we're managing our own recipe we might as well add exclusive features that cannot be supported otherwise 😄

This reverts commit e90582b.
Running Cargo without explicitely providing a channel will use the requested version in `rust-toolchain.toml`, it will be downloaded if it is not already installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants