Add atomic fallback for CXX without std::atomic #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cguimaraes
reviewed
Jan 16, 2024
CMakeLists.txt
Outdated
| @@ -62,6 +62,11 @@ endif() | |||
| set(CMAKE_C_STANDARD_REQUIRED TRUE) | |||
| add_definition(ZENOH_C_STANDARD=${CMAKE_C_STANDARD}) | |||
|
|
|||
| # Useful for CXX platforms that don't provide std::atomic | |||
| if(CXX_ATOMIC_FALLBACK) | |||
There was a problem hiding this comment.
Could you validate this using check_cxx_source_compiles? In that way, the fallback would happen automatically without the need for the user to specify this flag.
There was a problem hiding this comment.
Updated to use check_cxx_source_compiles it works on my machine, but it seems that the CI doesn't expose it
PetervdPerk-NXP
force-pushed
the
pr-zenoh-cxx-atomic
branch
from
e9d2e0c to
173b767
Compare
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| #if ZENOH_C_STANDARD != 99 | |||
|
|
|||
| #ifndef __cplusplus | |||
| #if !defined(__cplusplus) || ZENOH_CXX_ATOMIC_FALLBACK | |||
Check warning
Code scanning / Cppcheck (reported by Codacy)
misra violation 2009 with no text in the supplied rule-texts-file Warning
PetervdPerk-NXP
force-pushed
the
pr-zenoh-cxx-atomic
branch
from
173b767 to
e8eb74b
Compare
|
I think this is fixed by: #552 |
|
Indeed #547 hides the actual atomic functions from CXX thus we CXX atomics aren't needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling zenoh-pico on an embedded rtos without std::atomic you'll get
<atomic>include errors. This patch provides a way to implement some of the c11 atomics used inpointer.hin CXX.It's just an attempt maybe someone has an idea for a cleaner approach, also it's the question other parts of zenoh-pico are going to utilize c11 atomic.