Replace session pointer with refcount #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: build tests only in c11 * fix: remove c11 macros from examples * feat: add a way to force c99 standard * ci: add a c99 compilation test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
p-avital
reviewed
Jan 17, 2024
| #define _Z_REFCOUNT_DEFINE(name, type) \ | ||
| typedef struct name##_rc_t { \ | ||
| type##_t *ptr; \ | ||
| _z_atomic(unsigned int) * _cnt; \ |
There was a problem hiding this comment.
Why not define a struct name##_rc_inner_t {type##_t value; _z_atomic(unsigned int) _cnt;}; and have a single pointer to it?
There was a problem hiding this comment.
That's an interesting suggestion.
|
Have to close this one with the main branch renaming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entities
sessionpublisher,subscriberandqueryableswere sharing ownership of the same_z_session_tpointer, this caused issues like #312. This PR replaces the session pointer with a refcounter on the session pointer.Had to modify how the refcount implementation was handled:
And renamed
pointer.h/_sptr_ttorefcount.h/_rc_t