Improve Timestamp.seconds_since_unix_epoch()

eclipse-zenoh · Sep 15, 2023 · 72867fa · 72867fa
1 parent b8f16f1
commit 72867fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/value.rs b/src/value.rs
@@ -195,15 +195,7 @@ impl _Timestamp {
     }
     #[getter]
     pub fn seconds_since_unix_epoch(&self) -> PyResult<f64> {
-        match self
-            .0
-            .get_time()
-            .to_system_time()
-            .duration_since(std::time::UNIX_EPOCH)
-        {
-            Ok(o) => Ok(o.as_secs_f64()),
-            Err(e) => Err(e.to_pyerr()),
-        }
+        Ok(self.0.get_time().as_secs_f64())
     }
 }
 

diff --git a/zenoh/value.py b/zenoh/value.py
@@ -118,7 +118,8 @@ def seconds_since_unix_epoch(self) -> float:
         """
         Returns the number of seconds since the Unix Epoch.
 
-        You shouldn't use this for comparison though, and rely on comparison operators between members of this class.
+        Considering the large number of seconds since the Unix Epoch, the precision of the resulting f64 is in the order of microseconds.
+        Therefore, it should not be used for comparison. Directly comparing Timestamp objects is preferable.
         """
         return super().seconds_since_unix_epoch