Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Release workflow #124

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

fuzzypixelz
Copy link
Member

Context

  • zenoh-link-quic now indirectly depends on ring 0.17 through rustls-webpki.
  • ring 0.17 depends on a version of BoringSSL that requires GCC/Clang to provide __ARM_ARCH
  • When setting the manylinux tag to 'auto', messense/maturin-action@v1 uses the manylinux2014 docker image to compile for for aarch64
  • the GCC included in the manylinux2014 docker image doesn't provide __ARM_ARCH

This was reported and discussed here: briansmith/ring#1728. Naturally, the Release workflow is broken. Still, I can't tell why manylinux2014 is still working for armv7.

Changes

As a workaround, this PR specifies manylinux_2_28 for (and only for) the Linux Aarch64 target. This way, the other targets can still enjoy greater compatibility with (older) Linux distros.

@Mallets Mallets merged commit 7650c50 into eclipse-zenoh:master Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants