Remove unused Ack message

commons/zenoh-codec/src/zenoh/mod.rs

@@ -11,7 +11,6 @@
 // Contributors:
 //   ZettaScale Zenoh Team, <[email protected]>
 //
-pub mod ack;
 pub mod del;
 pub mod err;
 pub mod pull;
@@ -122,7 +121,6 @@ where
         match x {
             ResponseBody::Reply(b) => self.write(&mut *writer, b),
             ResponseBody::Err(b) => self.write(&mut *writer, b),
-            ResponseBody::Ack(b) => self.write(&mut *writer, b),
             ResponseBody::Put(b) => self.write(&mut *writer, b),
         }
     }
@@ -141,7 +139,6 @@ where
         let body = match imsg::mid(codec.header) {
             id::REPLY => ResponseBody::Reply(codec.read(&mut *reader)?),
             id::ERR => ResponseBody::Err(codec.read(&mut *reader)?),
-            id::ACK => ResponseBody::Ack(codec.read(&mut *reader)?),
             id::PUT => ResponseBody::Put(codec.read(&mut *reader)?),
             _ => return Err(DidntRead),
         };

commons/zenoh-codec/tests/codec.rs

@@ -582,11 +582,6 @@ fn codec_err() {
     run!(zenoh::Err, zenoh::Err::rand());
 }
 
-#[test]
-fn codec_ack() {
-    run!(zenoh::Ack, zenoh::Ack::rand());
-}
-
 #[test]
 fn codec_pull() {
     run!(zenoh::Pull, zenoh::Pull::rand());

commons/zenoh-protocol/src/zenoh/mod.rs

@@ -11,7 +11,6 @@
 // Contributors:
 //   ZettaScale Zenoh Team, <[email protected]>
 //
-pub mod ack;
 pub mod del;
 pub mod err;
 pub mod pull;
@@ -20,7 +19,6 @@ pub mod query;
 pub mod reply;
 
 use crate::core::Encoding;
-pub use ack::Ack;
 pub use del::Del;
 pub use err::Err;
 pub use pull::Pull;
@@ -35,8 +33,7 @@ pub mod id {
     pub const QUERY: u8 = 0x03;
     pub const REPLY: u8 = 0x04;
     pub const ERR: u8 = 0x05;
-    pub const ACK: u8 = 0x06;
-    pub const PULL: u8 = 0x07;
+    pub const PULL: u8 = 0x06;
 }
 
 // DataInfo
@@ -127,7 +124,6 @@ impl From<Del> for RequestBody {
 pub enum ResponseBody {
     Reply(Reply),
     Err(Err),
-    Ack(Ack),
     Put(Put),
 }
 
@@ -138,11 +134,10 @@ impl ResponseBody {
 
         let mut rng = rand::thread_rng();
 
-        match rng.gen_range(0..4) {
+        match rng.gen_range(0..3) {
             0 => ResponseBody::Reply(Reply::rand()),
             1 => ResponseBody::Err(Err::rand()),
-            2 => ResponseBody::Ack(Ack::rand()),
-            3 => ResponseBody::Put(Put::rand()),
+            2 => ResponseBody::Put(Put::rand()),
             _ => unreachable!(),
         }
     }
@@ -160,12 +155,6 @@ impl From<Err> for ResponseBody {
     }
 }
 
-impl From<Ack> for ResponseBody {
-    fn from(r: Ack) -> ResponseBody {
-        ResponseBody::Ack(r)
-    }
-}
-
 pub mod ext {
     use zenoh_buffers::ZBuf;
 

zenoh/src/session.rs

@@ -2247,11 +2247,6 @@ impl Primitives for Session {
     fn send_response(&self, msg: Response) {
         trace!("recv Response {:?}", msg);
         match msg.payload {
-            ResponseBody::Ack(_) => {
-                log::warn!(
-                    "Received a ResponseBody::Ack, but this isn't supported yet. Dropping message."
-                )
-            }
             ResponseBody::Put(_) => {
                 log::warn!(
                     "Received a ResponseBody::Put, but this isn't supported yet. Dropping message."