Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint config should not be overwritten by Zenoh config file #1634

Closed
oteffahi opened this issue Dec 6, 2024 · 0 comments · Fixed by #1635
Closed

Endpoint config should not be overwritten by Zenoh config file #1634

oteffahi opened this issue Dec 6, 2024 · 0 comments · Fixed by #1635
Assignees
Labels
bug Something isn't working

Comments

@oteffahi
Copy link
Contributor

oteffahi commented Dec 6, 2024

Describe the bug

Some link configurations can either be passed by endpoint parameters or via the zenoh config file. Currently the config file is given priority over endpoint parameters, which shouldn't be the case. Config file should be a fallback if no config is given on the specific endpoint.

To reproduce

  1. Create a zenoh config file with TLS config.
  2. Set transport/link/tls/enable_mtls to true.
  3. Set listen/endpoints to ["tls/[::]:7447#enable_mtls=false"]
  4. Start a peer/router with the config file, connect to it with a client via tls and notice how mtls is enabled.

System info

Zenoh 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant