Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize endpoint config over configuration file, add interface binding for TLS link #1635

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Prioritize endpoint config over configuration file, add interface binding for TLS link #1635

merged 4 commits into from
Dec 10, 2024

Conversation

oteffahi
Copy link
Contributor

@oteffahi oteffahi commented Dec 6, 2024

Closes #1634

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

PR missing one of the required labels: {'breaking-change', 'dependencies', 'documentation', 'bug', 'new feature', 'enhancement', 'internal'}

@oteffahi oteffahi requested a review from Mallets December 6, 2024 15:36
@oteffahi oteffahi added the bug Something isn't working label Dec 6, 2024
@oteffahi oteffahi self-assigned this Dec 6, 2024
@oteffahi oteffahi requested a review from Mallets December 9, 2024 12:02
@Mallets Mallets merged commit 74c7732 into eclipse-zenoh:main Dec 10, 2024
13 checks passed
@oteffahi oteffahi changed the title Prioritize endpoint config over configuration file Prioritize endpoint config over configuration file, add interface binding for TLS Dec 10, 2024
@oteffahi oteffahi changed the title Prioritize endpoint config over configuration file, add interface binding for TLS Prioritize endpoint config over configuration file, add interface binding for TLS links Dec 10, 2024
@oteffahi oteffahi changed the title Prioritize endpoint config over configuration file, add interface binding for TLS links Prioritize endpoint config over configuration file, add interface binding for TLS link Dec 10, 2024
@oteffahi oteffahi added the new feature Something new is needed label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@OlivierHecart OlivierHecart Awaiting requested review from OlivierHecart

Assignees

@oteffahi oteffahi

Labels
bug Something isn't working new feature Something new is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint config should not be overwritten by Zenoh config file
2 participants
@oteffahi @Mallets