Enhance subscribers, queryables and liveliness tokens propagation to improve scalability for peers subsystems #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierHecart
force-pushed
the
peers_interests
branch
3 times, most recently
from
8015954 to
850f26c
Compare
OlivierHecart
force-pushed
the
peers_interests
branch
from
850f26c to
d7bb636
Compare
Mallets
reviewed
May 27, 2024
|
@OlivierHecart please add a description on the actual changes introduced by this PR. |
Mallets
approved these changes
May 30, 2024
fuzzypixelz
approved these changes
May 30, 2024
| } else { | ||
| for src_face in tables | ||
| .faces | ||
| face_hat_mut!(face) |
There was a problem hiding this comment.
If I understand correctly. Now we receive all the Subscriber declarations from the Router connected to one of the node in the peer-to-peer subsystem. Thus we need only forward peer Interest declarations to the Router and expect to receive Subscriber declarations.
I write this just to confirm that I understand the purpose of this change.
There was a problem hiding this comment.
Before, when receiving interest from a client, a peer only had to answer its interest with its local knowledge of subscribers. Now it needs to propagate this interest to Routers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Interest protocol profile used from routers to peers. Previous profile was Pushed declarations, new profile is Pulled declarations. (See Notion).
In other words the Subscriber and Queryable declarations are not pushed any more from routers to peers but pulled by peers through the interest protocol.