-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove zenoh_util from examples #1061
fix: remove zenoh_util from examples #1061
Conversation
This PR is based on #1007, so it will be draft until its base is merged. |
0e05fd4
to
9dd8d00
Compare
Users should not use `zenoh_util::try_init_log_from_env`. They should instead register their own subscriber with their own formatting preferences. Examples provides a basic logging initialization that users can copy-paste if they don't want to learn tracing.
9dd8d00
to
d854939
Compare
I believe keeping something like
I'd also prefer to keep something like @milyin opinions? |
Bindings should try to bind zenoh logs to the language logging system, e.g. for Python redirect tracing events to a My argument against The other issue was that |
I think we are missing an important point here. You get zenoh, you get easily some output. I think we should keep this capability of easily do it from the user perspective. |
Ok, so I can close this PR. But my point about the bindings doesn't change: we should provide zenoh logs in a "native" way for the different bindings, at least for the Python one; C/C++ can wait users asking for it i guess. |
Users should not use
zenoh_util::try_init_log_from_env
. They should insteadregister their own subscriber with their own formatting preferences.
Examples provides a basic logging initialization that users can copy-paste
if they don't want to learn tracing.
@Mallets @milyin @gabrik