Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replier_id() returns Option<ZenohId> #1138

Merged
merged 2 commits into from
Jun 14, 2024
Merged

replier_id() returns Option<ZenohId> #1138

merged 2 commits into from
Jun 14, 2024

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Jun 13, 2024

Fix for issue #709
Also leak of ZenohIdProto fixed

@wyfo
Copy link
Contributor

wyfo commented Jun 14, 2024

LGTM, also, you can trigger the CI again, it should work

@fuzzypixelz fuzzypixelz added the bug Something isn't working label Jun 14, 2024
@milyin milyin merged commit 2a43a1d into dev/1.0.0 Jun 14, 2024
16 of 17 checks passed
@Mallets Mallets deleted the option_replier_id branch June 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants