Optimize RoutingContext keyexpr for Query and Response messages #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on existing Push message logic
|
@OlivierHecart @Mallets Requesting reviews. Thnx! |
|
@fuzzypixelz Could you please add the |
|
Current key_expr routing context for |
OlivierHecart
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replicates Push egress routing logic for Query, Response and ResponseFinal messages. Skips allocation of
Stringfor theRoutingContexton the critical path of each message, which should improve performance.Also includes fix to flaky Authentication lowlatency transport test (See issue #1267).
Closes #1255