Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make session an arc-like object #1347

Merged
merged 38 commits into from
Sep 6, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Sep 3, 2024

The refactoring is quite deep, so this is the first (dirty) iteration which passes the tests.

The branch is based on #1334, which should be merged first

Copy link

github-actions bot commented Sep 3, 2024

PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal

Allow transport defragmentation errors and fix dropping of old transport messages
@Mallets Mallets changed the base branch from main to dev/arcsession September 3, 2024 10:50
@Mallets
Copy link
Member

Mallets commented Sep 3, 2024

@wyfo I've changed the base branch from main to dev/arcsession. All other bindings can then use dev/arcsession for development.

Copy link

github-actions bot commented Sep 3, 2024

PR missing one of the required labels: {'dependencies', 'breaking-change', 'bug', 'new feature', 'internal', 'enhancement', 'documentation'}

Copy link

github-actions bot commented Sep 3, 2024

PR missing one of the required labels: {'breaking-change', 'enhancement', 'new feature', 'documentation', 'dependencies', 'internal', 'bug'}

@wyfo wyfo added enhancement Existing things could work better breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Sep 3, 2024
@wyfo wyfo marked this pull request as ready for review September 3, 2024 15:16
oteffahi and others added 3 commits September 3, 2024 17:15
Bumps [quinn-proto](https://github.com/quinn-rs/quinn) from 0.11.3 to 0.11.8.
- [Release notes](https://github.com/quinn-rs/quinn/releases)
- [Commits](quinn-rs/quinn@quinn-proto-0.11.3...quinn-proto-0.11.8)

---
updated-dependencies:
- dependency-name: quinn-proto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
OlivierHecart and others added 16 commits September 4, 2024 11:24
Co-authored-by: Luca Cominardi <[email protected]>
…argo/quinn-proto-0.11.8

chore(deps): bump quinn-proto from 0.11.3 to 0.11.8
To determine if the entity is callback-only, the only elegant way I've found is the rule "handler is ZST means callback-only". Unless users starts writing fancy implementations, it should be correct 100% of the time.

Session entities now uses weak references, except publishers because it would impact performances. Weak references also solves the issue of mass undeclarations before closing the session (when the session is an `Arc`), except for publishers.

`Undeclarable` trait has been refactored a little bit to better match its use in the code.
The refactoring is quite deep, so this is the first (dirty) iteration
which passes the tests.
@Mallets
Copy link
Member

Mallets commented Sep 6, 2024

Should we still merge #1334 merge first?

@Mallets
Copy link
Member

Mallets commented Sep 6, 2024

It seems you already included changes from current main into your branch. I'm going to merge this PR in dev/arcsession and opening a PR from dev/arcsession to main so we have a proper diff.

@Mallets Mallets merged commit 18f95c0 into eclipse-zenoh:dev/arcsession Sep 6, 2024
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants