Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improving pluging feature #1422

Merged
merged 9 commits into from
Sep 17, 2024
Merged

feat: improving pluging feature #1422

merged 9 commits into from
Sep 17, 2024

Conversation

gabrik
Copy link
Contributor

@gabrik gabrik commented Sep 16, 2024

Adding a feature for a more fine graned control on plugins loading

@gabrik gabrik added enhancement Existing things could work better internal Changes not included in the changelog labels Sep 16, 2024
@gabrik gabrik force-pushed the feat/improved-plugin-features branch from 66f4f1b to 59e33f4 Compare September 17, 2024 07:40
@gabrik
Copy link
Contributor Author

gabrik commented Sep 17, 2024

@gabrik gabrik requested a review from Mallets September 17, 2024 09:03
@gabrik gabrik marked this pull request as ready for review September 17, 2024 09:03
@Mallets
Copy link
Member

Mallets commented Sep 17, 2024

To handle optional dependency we may invert the feature logic.
You could add a static_plugins_loading feature that enables async-std dependency.

@Mallets Mallets merged commit 7f396ec into main Sep 17, 2024
24 checks passed
@Mallets Mallets deleted the feat/improved-plugin-features branch September 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants