-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improving pluging feature #1422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrik <[email protected]>
gabrik
added
enhancement
Existing things could work better
internal
Changes not included in the changelog
labels
Sep 16, 2024
Signed-off-by: gabrik <[email protected]>
…tokio runtime Signed-off-by: Gabriele Baldoni <[email protected]>
gabrik
force-pushed
the
feat/improved-plugin-features
branch
from
September 17, 2024 07:40
66f4f1b
to
59e33f4
Compare
Signed-off-by: Gabriele Baldoni <[email protected]>
Signed-off-by: Gabriele Baldoni <[email protected]>
Testing with this branch passes: https://github.com/ZettaScaleLabs/zenoh-tests/actions/runs/10899702613/job/30245686591 |
To handle optional dependency we may invert the feature logic. |
Signed-off-by: Gabriele Baldoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a feature for a more fine graned control on plugins loading