Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depdendencies #1424

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Update depdendencies #1424

merged 3 commits into from
Sep 17, 2024

Conversation

fuzzypixelz
Copy link
Member

Not much to say here.

@fuzzypixelz fuzzypixelz added enhancement Existing things could work better internal Changes not included in the changelog labels Sep 16, 2024
@fuzzypixelz fuzzypixelz requested a review from Mallets September 16, 2024 14:22
@fuzzypixelz fuzzypixelz self-assigned this Sep 16, 2024
@Mallets
Copy link
Member

Mallets commented Sep 16, 2024

@fuzzypixelz can we make sure the change is reflected in the Cargo.toml as well?

@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Sep 16, 2024

@Mallets The Cargo.toml specifies version ranges, this pull request bumps dependencies within those ranges.

For example tokio has been bumped from 1.39.3 to 1.40.0 because in Cargo.toml we got tokio = "1.39.3" and that means any 1.x.y version where x >= 39 and y >= 3.

Same goes for tokio-util which went from 0.7.11 to 0.7.12.

Updating the Cargo.toml is only necessary if we go through semver-incompatible changes, which is beyond the scope of this pull request.

@Mallets
Copy link
Member

Mallets commented Sep 16, 2024

It should be in the scope of the next -rc for Zenoh. Even though cargo does what you described, it would be good to have the version bumped and verify that Zenoh depends on the very latest crates.

@fuzzypixelz
Copy link
Member Author

It should be in the scope of the next -rc for Zenoh. Even though cargo does what you described, it would be good to have the version bumped and verify that Zenoh depends on the very latest crates.

So we want to potentially deal with breaking changes in dependencies?

@Mallets
Copy link
Member

Mallets commented Sep 16, 2024

I think we need to first try to bump all the dependencies. If some breaking change appears, then we will make a call wether we want to bump that specific dependency or not.

@fuzzypixelz
Copy link
Member Author

@Mallets Done.

@Mallets Mallets enabled auto-merge (squash) September 17, 2024 19:51
@Mallets Mallets merged commit 993cee5 into main Sep 17, 2024
23 checks passed
@fuzzypixelz fuzzypixelz deleted the update-deps branch October 8, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants