Rework deserialization errors #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
added
the
breaking-change
fuzzypixelz
changed the title
zenoh_buffers::reader::DidntRead
fuzzypixelz
changed the title
|
Superseded by #1447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request unifies the error types used in deserialization:
ZDeserializeErrorDidntRead(wasn't exposed anyway)ZReadOrDeserializeError(wasn't exposed anyway)ZReadOrDeserializeErrorTuple2(wasn't exposed anyway)ZReadOrDeserializeErrorTuple3(wasn't exposed anyway)ZReadOrDeserializeErrorTuple3(wasn't exposed anyway)ZReadOrDeserializeErrorTuple4(wasn't exposed anyway)All references to
DidntReadare removed, and everything is merged inZDeserializeError. AllZReadOr-ish types are removed as they expose an implementation detail (why should a caller know about Codec? I don't get any extra info fromDidntReadanyway).In the future,
ZDeserializeErrorcan have a.kind()method so that the API caller to distinguish cases.