Notify subscribers on Notifier<Config>::insert_json5
#1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
added
bug
Mallets
approved these changes
Sep 18, 2024
Mallets
added a commit
that referenced
this pull request
Sep 19, 2024
* Fix docs * Align naming style of `zenoh_config::defaults` (#1423) * Put `SourceSn` behind unstable (#1448) * Notify subscribers on `Notifier<Config>::insert_json5` (#1449) * Hide `zenoh_buffers::reader::DidntRead` (#1447) * Apply suggestions from code review Co-authored-by: Mahmoud Mazouz <[email protected]> * Add #[doc(hidden)] to internal_config feature * Update ZBytes docs * Update ZSerde docs * Update ZSerde docs * Fix ZBytesIterator docs * Fix ZBytesWriter and ZBytesReader docs * Fix ZBytesSliceIterator docs * Fix ZenohId docs * Fix docstring * Improve FifoChannel and RingChannel docs --------- Co-authored-by: Mahmoud Mazouz <[email protected]> Co-authored-by: Joseph Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot the
.notify()call in #1419.cc @oteffahi