Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the public API #1462

Merged
merged 23 commits into from
Sep 20, 2024
Merged

Polish the public API #1462

merged 23 commits into from
Sep 20, 2024

Conversation

fuzzypixelz
Copy link
Member

n/a

fuzzypixelz and others added 22 commits September 19, 2024 15:24
@fuzzypixelz
Hide ZBuf-related impls
86953f7
@fuzzypixelz
Hide ZSlice-related impls
45dee15
@fuzzypixelz
Hide zenoh_keyexpr::key_expr::format::macro_support::*
2f9b77a
@fuzzypixelz
One line short desc for try_init_log_from_env
dd28024
@fuzzypixelz
Improve CongestionControl docs
b41676e
@fuzzypixelz
Improve Priority docs
231e4b1
@fuzzypixelz
Improve ReplyKeyExpr docs
f2ea58a
@fuzzypixelz
Improve ReplyKeyExpr docs
4e6103c
@fuzzypixelz
Improve ZAllocError docs
8da24b6
@fuzzypixelz
Improve ZLayoutAllocError docs
570483c
@fuzzypixelz
Improve ZLayoutError docs
aa99cb3
@fuzzypixelz
Fix SyncResolve deprecation message
c8c3a3f
@Mallets
Improve serialize/deserialize trait doc
2a794cf
@fuzzypixelz
Hide zenoh::FEATURES in docs
b217899
@fuzzypixelz
Make SubscriberBuilder pub only on internal
4da3c7c
@fuzzypixelz
Fix SubscriberBuilder docs
86d5434
@fuzzypixelz
Improve Publication docs
3b66c06
@fuzzypixelz
Remove SubscriberBuilder Reliability options
93b2754
@fuzzypixelz
Make handlers::locked internal
2e30d37
@fuzzypixelz
Merge remote-tracking branch 'origin/main' into polish-public-api
ea1b9cb
@fuzzypixelz
Make handlers::locked internal properly
f419105
@fuzzypixelz
Remove unused import
1e17a31
@fuzzypixelz fuzzypixelz added documentation Improvements or additions to documentation enhancement Existing things could work better breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Sep 20, 2024
@fuzzypixelz fuzzypixelz self-assigned this Sep 20, 2024
@Mallets Mallets enabled auto-merge (squash) September 20, 2024 10:15
@wyfo
Copy link
Contributor

wyfo commented Sep 20, 2024 •
edited
Loading

Why do we want a huge breaking change that can be avoided simply?

@Mallets Mallets merged commit 94ba6f3 into main Sep 20, 2024
23 checks passed
@fuzzypixelz fuzzypixelz mentioned this pull request Sep 20, 2024
Closed
@Mallets Mallets deleted the polish-public-api branch September 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees

@fuzzypixelz fuzzypixelz

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) documentation Improvements or additions to documentation enhancement Existing things could work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuzzypixelz @wyfo @Mallets