Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downsampling id and update config comment #1759

Merged

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 5, 2025

Add downsampling id for add possibility to identify the rule.
And update config comment to clarify interfaces field usage.

Copy link

github-actions bot commented Feb 5, 2025

PR missing one of the required labels: {'breaking-change', 'new feature', 'internal', 'documentation', 'bug', 'dependencies', 'enhancement'}

@sashacmc sashacmc added the internal Changes not included in the changelog label Feb 5, 2025
@sashacmc sashacmc marked this pull request as ready for review February 5, 2025 16:27
@@ -240,7 +240,10 @@
// /// The downsampling declaration.
// downsampling: [
// {
// /// A list of network interfaces messages will be processed on, the rest will be passed as is.
// /// Optional Id, has to be unique
// "id": "wlan0ergess",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@OlivierHecart OlivierHecart enabled auto-merge (squash) February 6, 2025 14:38
@OlivierHecart OlivierHecart merged commit 22e6b2e into eclipse-zenoh:main Feb 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants