Add protocol extensions for user attachment #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
commented
Dec 14, 2023
examples/examples/z_pub_thr.rs
Outdated
|
|
||
| let data: Value = (0usize..size) | ||
| let data: Value = (0usize..dbg!(payload_size)) |
There was a problem hiding this comment.
forgot to remove it, done now
|
This PR introduces a throughput regression of Approving this PR so as to unblock eclipse-zenoh/zenoh-c#203 and eclipse-zenoh/zenoh-cpp#86. |
p-avital
approved these changes
Dec 14, 2023
p-avital
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
attachmentextension toPut,Del,Query, andReplyZenoh messages.This is a necessary step to allow the user to attach any arbitrary metadata to
put,del,query, andreplyoperations.An example of some on-going effort of such API in zenoh-c can be found here: eclipse-zenoh/zenoh-c#190
Although I believe this PR will not evolve any further, I'll keep it in Draft for the time being since a validation with a full attachment API is desirable before merging.
In addition, this PR explicitly deconstructs any type in the write codec in such a way that, anytime a new protocol extension is added, the compiler will highlight where the new extension needs to be handled in the code.