Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak fixes #625

Closed
wants to merge 4 commits into from
Closed

memory leak fixes #625

wants to merge 4 commits into from

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Dec 14, 2023

Fixes memory leaks due to:

  • cyclic reference Runtime <- Network '<- Tables <-TableLock <- Router <- RuntimeState <- Runtime
  • captured sender end of channel by receiver task, which should end when all senders are gone in TransportManager::new()
  • cyclic reference Runtime <- RuntimeTransportEventHandler <- TransportManager <- RuntimeState <- Runtime

To do:

  • fix cyclic reference to Session from admin space handler in Session::init
  • fix (or decide to ignore, to be ivestigated) leak due to not waiting to end of all threads stated by TransportExecutor::new (5a8df0f)

@fuzzypixelz
Copy link
Member

@milyin Please change your pull request's base branch to main (new default branch). And rebase your branch against main as it is missing a status check necessary to merge this pull request but which is only available on main.

@milyin milyin added the bug Something isn't working label Jan 25, 2024
@milyin milyin changed the base branch from master to main January 25, 2024 14:52
@milyin milyin mentioned this pull request Feb 2, 2024
@milyin milyin closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants