Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce status checks #639

Merged

Conversation

fuzzypixelz
Copy link
Member

In GitHub repository settings, the "Require status checks to pass before merging" branch protection rule ensures that commits are only merged from branches where specific status checks have passed. These checks are specified manually as a list of workflow job names.

To properly use the branch protection rule, we need this additional 'all encompassing' status check. Without this, GitHub won't wait for status checks when auto-merging pull requests.

Further context and a more feature-full implementation is available at: https://github.com/re-actors/alls-green. Although we don't (currently) need an 'allow skips' or 'allow failures' option so the value of adding yet another dependency is questionable.

Needless to say, this change needs to be propagated to all other eclipse-zenoh/zenoh-* repositories. We could add this logic in an action under .github/actions/reduce-status-checks.yml and use that from the other repositories. However, all we would factor out is the jq command (and maybe the comment/documentation). This makes for a good argument for using the existing re-actors/alls-green action.

@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Jan 3, 2024

When running tests, the cargo install nextest step takes 5-8mins, which is nearly half the time is takes for the tests themselves to run. I switched to using pre-built binaries.

@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Jan 4, 2024

I removed the nightly requirement for nostd-check as it's no longer necessary. Moreover, now the nostd-check binary runs on Ubuntu/Windows/macOS instead of just Ubuntu as part of the check job.

The last commit status fails due to a spurious test failure, even though it was a simple workflow step name change. When we do enable branch protection these kind of failures might become an issue.

@OlivierHecart OlivierHecart merged commit 78acc13 into eclipse-zenoh:master Jan 5, 2024
8 checks passed
jerry73204 pushed a commit to NEWSLabNTU/zenoh that referenced this pull request Jan 12, 2024
* fix: Reduce status checks

* Add ci job name

* Use pre-built nextest binary

* Remove nightly toolchain requirement in nostd-check

* Fix deprecation warnings in `#![no_std]`

* Merge nostd job into check job

* Fix name of no_std target installation step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants