-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce status checks #639
Reduce status checks #639
Conversation
When running tests, the |
I removed the nightly requirement for The last commit status fails due to a spurious test failure, even though it was a simple workflow step name change. When we do enable branch protection these kind of failures might become an issue. |
* fix: Reduce status checks * Add ci job name * Use pre-built nextest binary * Remove nightly toolchain requirement in nostd-check * Fix deprecation warnings in `#![no_std]` * Merge nostd job into check job * Fix name of no_std target installation step
In GitHub repository settings, the "Require status checks to pass before merging" branch protection rule ensures that commits are only merged from branches where specific status checks have passed. These checks are specified manually as a list of workflow job names.
To properly use the branch protection rule, we need this additional 'all encompassing' status check. Without this, GitHub won't wait for status checks when auto-merging pull requests.
Further context and a more feature-full implementation is available at: https://github.com/re-actors/alls-green. Although we don't (currently) need an 'allow skips' or 'allow failures' option so the value of adding yet another dependency is questionable.
Needless to say, this change needs to be propagated to all other
eclipse-zenoh/zenoh-*
repositories. We could add this logic in an action under.github/actions/reduce-status-checks.yml
and use that from the other repositories. However, all we would factor out is thejq
command (and maybe the comment/documentation). This makes for a good argument for using the existing re-actors/alls-green action.